Make the div an anchor #711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR. I think it should be an anchor then, to match the rest of our buttons and avoid button-specific behavior and styling from browsers. |
Calinou
added
bug
topic:theme
|
Swapped for an anchor! |
LukeHendrick
changed the title
YuriSizov
reviewed
Oct 16, 2023
Comment on lines
+333
to
+343
| thankYouBackButton.addEventListener('keypress', (event) => { | ||
| // Support button enter and space interactions | ||
| switch (event.code.toUpperCase()) { | ||
| case "ENTER": | ||
| case "SPACE": | ||
| thankYouWrapper.style.display = 'none'; | ||
| break; | ||
| default: | ||
| break; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Why do we need this? Pressing enter already activates the link. Pressing space scrolls the page, but that's normal for web.
|
Sorry for the delay! The layout change seems good to me, but I'm not sure about the added code. |
|
Superseded by 2167a80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloaded the engine keyboard only, I was unable to close the modal. Swapped the div out for a button and made it transparent to be a little more accessible