Skip to content

Commit

Permalink
Refactor ColorPicker shapes
Browse files Browse the repository at this point in the history
  • Loading branch information
@KoBeWi
KoBeWi committed Dec 1, 2024
1 parent 893bbdf commit 04e059f
Show file tree
Hide file tree
Showing 5 changed files with 841 additions and 382 deletions.
1 change: 0 additions & 1 deletion scene/gui/color_mode.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ class ColorMode {
virtual ColorPicker::PickerShapeType get_shape_override() const { return ColorPicker::SHAPE_MAX; }

ColorMode(ColorPicker *p_color_picker);
virtual ~ColorMode() {}
};

class ColorModeHSV : public ColorMode {

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🌐 Web / Template w/o threads (target=template_release, threads=no) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🌐 Web / Template w/o threads (target=template_release, threads=no) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🌐 Web / Template w/ threads (target=template_release, threads=yes) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🌐 Web / Template w/ threads (target=template_release, threads=yes) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🤖 Android / Template arm64 (target=template_release, arch=arm64) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🤖 Android / Template arm64 (target=template_release, arch=arm64) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🤖 Android / Template arm32 (target=template_release, arch=arm32) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🤖 Android / Template arm32 (target=template_release, arch=arm32) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🍏 iOS / Template (target=template_release) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🍎 macOS / Template (target=template_release, tests=yes) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, tests=yes, everything disabled) 

base class 'class ColorMode' has accessible non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Minimal template (target=template_release, tests=yes, everything disabled) 

'class ColorModeHSV' has virtual functions and accessible non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🤖 Android / Editor (target=editor) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor) 

base class 'class ColorMode' has accessible non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor w/ Mono (target=editor) 

'class ColorModeHSV' has virtual functions and accessible non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🍎 macOS / Editor (target=editor, tests=yes) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor with clang sanitizers (target=editor, tests=yes, dev_build=yes, use_asan=yes, use_ubsan=yes, use_llvm=yes, linker=lld) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor with clang sanitizers (target=editor, tests=yes, dev_build=yes, use_asan=yes, use_ubsan=yes, use_llvm=yes, linker=lld) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor with ThreadSanitizer (target=editor, tests=yes, dev_build=yes, use_tsan=yes, use_llvm=yes, linker=lld) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor with ThreadSanitizer (target=editor, tests=yes, dev_build=yes, use_tsan=yes, use_llvm=yes, linker=lld) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Editor w/ clang-cl (target=editor, tests=yes, use_llvm=yes) 

'ColorModeHSV' has virtual functions but non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Template w/ Mono (target=template_release, tests=yes) 

base class 'class ColorMode' has accessible non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Template w/ Mono (target=template_release, tests=yes) 

'class ColorModeHSV' has virtual functions and accessible non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template w/ GCC (target=template_release, tests=yes, use_mingw=yes) 

base class 'class ColorMode' has accessible non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🏁 Windows / Template w/ GCC (target=template_release, tests=yes, use_mingw=yes) 

'class ColorModeHSV' has virtual functions and accessible non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor with doubles and GCC sanitizers (target=editor, tests=yes, dev_build=yes, scu_build=yes, precision=double, use_asan=yes, use_ubsan=yes, linker=gold) 

base class 'class ColorMode' has accessible non-virtual destructor

Check failure on line 60 in scene/gui/color_mode.h

View workflow job for this annotation

GitHub Actions / 🐧 Linux / Editor with doubles and GCC sanitizers (target=editor, tests=yes, dev_build=yes, scu_build=yes, precision=double, use_asan=yes, use_ubsan=yes, linker=gold) 

'class ColorModeHSV' has virtual functions and accessible non-virtual destructor
Expand Down
Loading

0 comments on commit 04e059f

Please sign in to comment.