Skip to content

Commit

Permalink
Merge pull request #80467 from aaronfranke/mesh-lod-limit
Browse files Browse the repository at this point in the history
Limit mesh complexity in LOD generation to prevent crashing
  • Loading branch information
akien-mga committed Sep 21, 2023
2 parents 4f314a6 + f95f2d1 commit 184e603
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions scene/resources/importer_mesh.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,14 @@ void ImporterMesh::generate_lods(float p_normal_merge_angle, float p_normal_spli
if (new_index_count == 0 || (new_index_count >= (index_count * 0.75f))) {
break;
}
if (new_index_count > 5000000) {
// This limit theoretically shouldn't be needed, but it's here
// as an ad-hoc fix to prevent a crash with complex meshes.
// The crash still happens with limit of 6000000, but 5000000 works.
// In the future, identify what's causing that crash and fix it.
WARN_PRINT("Mesh LOD generation failed for mesh " + get_name() + " surface " + itos(i) + ", mesh is too complex. Some automatic LODs were not generated.");
break;
}

new_indices.resize(new_index_count);

Expand Down

0 comments on commit 184e603

Please sign in to comment.