Fix invalid return from some _get/_set

Invalidly returned `true` on the non-matched path
godotengine · Oct 27, 2023 · b04cf84 · b04cf84
1 parent dd74ffd
commit b04cf84
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/scene/resources/bone_map.cpp b/scene/resources/bone_map.cpp
@@ -37,7 +37,7 @@ bool BoneMap::_set(const StringName &p_path, const Variant &p_value) {
 		set_skeleton_bone_name(which, p_value);
 		return true;
 	}
-	return true;
+	return false;
 }
 
 bool BoneMap::_get(const StringName &p_path, Variant &r_ret) const {
@@ -47,7 +47,7 @@ bool BoneMap::_get(const StringName &p_path, Variant &r_ret) const {
 		r_ret = get_skeleton_bone_name(which);
 		return true;
 	}
-	return true;
+	return false;
 }
 
 void BoneMap::_get_property_list(List<PropertyInfo> *p_list) const {

diff --git a/scene/resources/mesh.cpp b/scene/resources/mesh.cpp
@@ -1712,7 +1712,7 @@ bool ArrayMesh::_get(const StringName &p_name, Variant &r_ret) const {
 		return true;
 	}
 
-	return true;
+	return false;
 }
 
 void ArrayMesh::reset_state() {

diff --git a/scene/resources/skeleton_modification_stack_2d.cpp b/scene/resources/skeleton_modification_stack_2d.cpp
@@ -49,7 +49,7 @@ bool SkeletonModificationStack2D::_set(const StringName &p_path, const Variant &
 		set_modification(mod_idx, p_value);
 		return true;
 	}
-	return true;
+	return false;
 }
 
 bool SkeletonModificationStack2D::_get(const StringName &p_path, Variant &r_ret) const {
@@ -60,7 +60,7 @@ bool SkeletonModificationStack2D::_get(const StringName &p_path, Variant &r_ret)
 		r_ret = get_modification(mod_idx);
 		return true;
 	}
-	return true;
+	return false;
 }
 
 void SkeletonModificationStack2D::setup() {