Skip to content

Commit

Permalink
Revert "Display the Y angle properly when rotating from gizmo, partia…
Browse files Browse the repository at this point in the history
…lly helps #1479"

This reverts commit 641135b.
  • Loading branch information
akien-mga committed Aug 27, 2017
1 parent df70d28 commit b614622
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions core/math/matrix3.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#include "matrix3.h"
#include "math_funcs.h"
#include "os/copymem.h"
#include "print_string.h"

#define cofac(row1, col1, row2, col2) \
(elements[row1][col1] * elements[row2][col2] - elements[row1][col2] * elements[row2][col1])

Expand Down Expand Up @@ -169,16 +169,8 @@ Vector3 Matrix3::get_euler() const {
euler.y = Math::asin(m[0][2]);
if (euler.y < Math_PI * 0.5) {
if (euler.y > -Math_PI * 0.5) {
//if rotation is Y-only, return a proper -pi,pi range like in x or z for the same case.
if (m[1][0] == 0.0 && m[0][1] == 0.0 && m[0][0] < 0.0) {
if (euler.y > 0.0)
euler.y = Math_PI - euler.y;
else
euler.y = -(Math_PI + euler.y);
} else {
euler.x = Math::atan2(-m[1][2], m[2][2]);
euler.z = Math::atan2(-m[0][1], m[0][0]);
}
euler.x = Math::atan2(-m[1][2], m[2][2]);
euler.z = Math::atan2(-m[0][1], m[0][0]);

} else {
real_t r = Math::atan2(m[1][0], m[1][1]);
Expand Down

0 comments on commit b614622

Please sign in to comment.