Fix shader crash when using unary minus in expression

godotengine · Sep 11, 2024 · eadfeb3 · eadfeb3
1 parent 4788f54
commit eadfeb3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/servers/rendering/shader_compiler.cpp b/servers/rendering/shader_compiler.cpp
@@ -205,7 +205,7 @@ static String get_constant_text(SL::DataType p_type, const Vector<SL::Scalar> &p
 		}
 
 		case SL::TYPE_INT:
-			return itos(p_values[0].sint);
+			return itos(Math::abs(p_values[0].sint)); // To prevent writing unary minus twice.
 		case SL::TYPE_IVEC2:
 		case SL::TYPE_IVEC3:
 		case SL::TYPE_IVEC4: {
@@ -238,7 +238,7 @@ static String get_constant_text(SL::DataType p_type, const Vector<SL::Scalar> &p
 			return text;
 		} break;
 		case SL::TYPE_FLOAT:
-			return f2sp0(p_values[0].real);
+			return f2sp0(Math::abs(p_values[0].real)); // To prevent writing unary minus twice.
 		case SL::TYPE_VEC2:
 		case SL::TYPE_VEC3:
 		case SL::TYPE_VEC4: {