Boot splash image is also used when Godot editor starts

[andrea-calligaris]

Godot version:
Master

Issue:
Issue #4739 has been closed, but in master, if you choose an image for the boot splash, it's also used by Godot editor when it opens your project. If this is intended, I don't think it is a reasonable behavior.

Steps to reproduce:
Set a custom splash image in your project. Now it is used when your game boots.
Notice that it's also used by the Godot editor when it opens your project: some may like this, others may not.
This is especially important when the user replaces the boot splash with a blank image because he's using a custom splash screen scene. As an unexpected side effect, he will get a black boot splash when he opens his game project with the Godot editor.

Example project:
boot_splash.zip

[akien-mga]

I don't mind either way, but yeah it can be fixed not to load the bootsplash of the project.

[avril-gh]

i like this behavior, it does not start when editor starts.
It starts when certain project is worked on with boot image related to this project.

[andrea-calligaris]

@avril-gh What if you have a black empty boot splash because your project has its own splash screen scene? You may still want to see Godot's boot splash when you load your Godot project, instead of an empty black window.

[avril-gh]

matter of taste,

What if you have a black empty boot splash (...) and want something different (...) instead of an empty black window.

um... ... .........
it need fiew flowers ! ❤️

[andrea-calligaris]

@avril-gh My post is clear enough, try reading it again. The user may still want Godot's editor to show its boot splash. Godot's editor is not your game.
About the "matter of taste", of course, but there should be the possibility to choose.

[williamd1k0]

@char0xff What if you have a black empty boot splash because your project has its own splash screen scene? You may still want to see Godot's boot splash when you load your Godot project, instead of an empty black window.

Same. I want to see Godot's boot splash 😅

[avril-gh]

no, i meant... 😹 ... what should be the answer to "i set a black screen and i dont like it ?"
Perhaps i should'nt answer at all, but... i just couldnt hold it.
Please forgive my sense of humor 💕

But serious, i seen fiew topics where discussion been about that on some devices splash is gone too fast and on others its hold for long time, and yet others like to add scene as spash ect.

Could just add a black screen with small "loading..." text in corner and then it "fixes" problem with different loading times, after which if someone like to use scene as splash then its a nice continuation.

Ofcourse there could be another solutions like add setting for "minimal" time for splash in seconds, which ensure that someones logo will be visible for that long independently from device speed and other factors.

If one meant the godot logo, it is allready shown by-default in editor and project (including exported project) if one not change it manualy in settings providing different splash, so imho the only problem here could be the time difference on how long it should be visible (in case of super quick init in fast devices)

[andrea-calligaris]

@avril-gh

"loading..." text in corner

No need for that, an option to disable the boot splash and have a black screen would be enough.

"minimal" time for splash in seconds

That would be useful, and there already are issues proposing this.

the godot logo, it is shown by default in editor and project if one not change it manualy

I know, this issue thread is about keeping the boot splash of Godot and the boot splash of your game two separate things, so that changing one does not change the other.

[avril-gh]

this issue thread is about keeping the boot splash of Godot and the boot splash of your game two separate things, so that changing one does not change the other

so you want to show two splash screens, one after another and with different combination's for editor, for edited game and perhaps released game ?

...you should change issue title and make first post to be more descriptive.

[akien-mga]

The issue is clear to me, I don't know why so much discussion is needed.

But yes, steps to reproduce (as asked by the template) would help to make it crystal clear :)

Basically:

• Set a custom splash screen in your project, it's used when you play your game -> YAY
• Then notice that it's also used when you open your project in the editor -> YAY for some, NAY for others

[andrea-calligaris]

Added an example project and steps to reproduce.

[aaronfranke]

It would make more sense to have Godot's splash screen when you run the editor. Since the thing running is not your project, but the editor, which opens your project.

It would also provide instant visual feedback that you didn't accidentally click "Run" instead of "Edit".

[KoBeWi]

It would also provide instant visual feedback that you didn't accidentally click "Run" instead of "Edit".

On the other hand, right now you get a feedback that you didn't open wrong project. Also you can edit project by double-clicking it. Personally, I never use the Edit button.

[MewPurPur]

Additional discovery - The minimum display time of the boot splash is used too.

[CaptainOtto]

Would love for there to be a specific one for editor and another one for the game project.

Because its 2 very different things, atleast the possibility to be able to pick a different one for each.

[Dancovich]

Would love for there to be a specific one for editor and another one for the game project.

It would be nice if all the splash screen configurations supported feature tags. It would solve this issue (as you could leave the splash screen with default values if editor feature tag is set) and also allows us to have different splash screens for different platforms of the game.

Other project settings already support feature tags, like the rendering device.

[akien-mga]

All project settings support feature tags, you can add them yourself if there's none preset.

Tested, it kinda works:

The main problem is that the editor feature tag is defined for both the editor instance, and for running the game with an editor binary (i.e. it's conditional to TOOLS_ENABLED in C++). We don't seem to have a feature tag that's equivalent to Engine.is_editor_hint() to know whether actually running the editor or a game with an editor binary.

[Dancovich]

I wasn't aware of that! Thanks.

Why then only some of these settings show in the project settings dialog without having to add them manually? Wouldn't this essentially fix this issue?

[Calinou]

PS: This issue also applies to the BG Color project setting:

We don't seem to have a feature tag that's equivalent to Engine.is_editor_hint() to know whether actually running the editor or a game with an editor binary.

This could probably be added now that we have other runtime feature tags such as movie.

Why then only some of these settings show in the project settings dialog without having to add them manually? Wouldn't this essentially fix this issue?

If we displayed optional overrides for every project setting, the dialog would become extremely convoluted.

[Dancovich]

We don't seem to have a feature tag that's equivalent to Engine.is_editor_hint() to know whether actually running the editor or a game with an editor binary.

I see.

Well, at least it's a workaround as I personally don't see not having my splash when debugging being that big of an issue.

As @Calinou said, maybe we could have a new feature tag for this scenario. It would also be an alternative to Engine.is_editor_hint() as even if that method is convenient, I think it's a little buried (I always forget it's a static method inside Engine) and checking feature tags is an engine wide feature so it makes sense to also be there.

Edit:

If we displayed optional overrides for every project setting, the dialog would become extremely convoluted.

I see your point. I honestly never noticed I could just click a setting and re-add it with a feature tag. I don't know if that's just me (it probably is) or if that's a feature that could be better advertised.

[Calinou]

I don't know if that's just me (it probably is) or if that's a feature that could be better advertised.

We could add context menu options to override a setting within a list of feature tags when right-clicking an option name in the Project Settings dialog. This would require special-casing the context menu that is displayed in EditorInspector, as this is only relevant in the project settings dialog and not anywhere else.