Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project option to allow boot splash disabling at editor startup #22967

Closed

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Oct 12, 2018

Added new option "Use At Editor Startup" to boot splash settings which allows disabling it and use the default one when the project has been loading, but not when the game actually runs. Its true by default so users could manually disable it for their projects. I tried EDITOR_DEF to allow it globally but it crashes(editor settings seems to be not fully loaded at the stage of project loading). Its my attempt to fix #22073.

@Chaosus Chaosus requested a review from reduz as a code owner October 12, 2018 18:38
@Chaosus Chaosus added this to the 3.1 milestone Oct 12, 2018
@Chaosus Chaosus force-pushed the allow_boot_splash_disabling branch from 062885f to abc637f Compare October 12, 2018 18:42
@Chaosus Chaosus force-pushed the allow_boot_splash_disabling branch from abc637f to a636636 Compare October 12, 2018 18:50
@Calinou
Copy link
Member

Calinou commented Oct 12, 2018

Does this need to be an option? I can't see any use cases for displaying the project splash screen when editing the project.

We have a lot of project/editor settings already, adding more of them needs to be justified.

@erodozer
Copy link

erodozer commented Oct 12, 2018

I don't know if this is an ok thing to have considering some patreon supporters pay big bucks to be included on the engine splash screen.

@Calinou
Copy link
Member

Calinou commented Oct 12, 2018

I don't know if this is an ok thing to have considering some patreon supporters pay big bucks to be included on the engine splash screen.

It's already possible to disable the custom editor splash screen by recompiling the engine with the no_editor_splash=yes option 🙂

@Chaosus
Copy link
Member Author

Chaosus commented Oct 13, 2018

Yeah, its not a useful option, if this is not desirable then what about closing #22073 also ?

@Chaosus
Copy link
Member Author

Chaosus commented Oct 25, 2018

Its useless decorative option which overcomplicate the engine, so I better close it.

@Chaosus Chaosus closed this Oct 25, 2018
@Chaosus Chaosus deleted the allow_boot_splash_disabling branch October 25, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boot splash image is also used when Godot editor starts
4 participants