Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler sometimes properly count time but sometimes not #29049

Closed
qarmin opened this issue May 20, 2019 · 2 comments · Fixed by #75623
Closed

Profiler sometimes properly count time but sometimes not #29049

qarmin opened this issue May 20, 2019 · 2 comments · Fixed by #75623
Labels
bug confirmed topic:editor
Milestone
4.3

Comments

@qarmin
Copy link
Contributor

qarmin commented May 20, 2019

Godot version:
3.2.dev.custom_build. af731f8

OS/device including version:
Ubuntu 19.04

Issue description:
When I check profiler, I got sometimes not properly time(Look at the Script Functions)
Zrzut ekranu z 2019-05-20 22-53-30
or this
Zrzut ekranu z 2019-05-20 22-52-56

this happens not all the time, here are correct time
Zrzut ekranu z 2019-05-20 22-52-48
@mbrlabs
Copy link
Contributor

mbrlabs commented Jun 13, 2020 •
edited
Loading

Same here:

ProfilerBug

BaseTile._ready takes 9.62ms while the total time for executing script functions only takes 5.19ms.
I'm not sure if this is a bug or me just not understanding how i should interpret the data, but i'm pretty sure that no single function sould take longer than the time shown for Script Functions.

Edit: This is running on 3.2.2rc1 and Windows 10

@Calinou
Copy link
Member

Calinou commented Jun 13, 2020

Related to #23715.

@reach-satori reach-satori mentioned this issue Apr 3, 2023
Merged
reach-satori added a commit to reach-satori/godot-prof-proj that referenced this issue Apr 21, 2023
@reach-satori
Fix missing time for some script functions in profiler
28d3ba3 
Fixes the issue by adding a mechanism by which the functions that were
previously disappearing can be profiled too. This is optional with
an editor setting, since collecting more information naturally slows the engine
further while profiling.

Fixes godotengine#23715, godotengine#40251, godotengine#29049
YuriSizov pushed a commit to reach-satori/godot-prof-proj that referenced this issue Dec 19, 2023
@reach-satori @YuriSizov
Fix missing time for some script functions in profiler
f1cc14d 
Fixes the issue by adding a mechanism by which the functions that were
previously disappearing can be profiled too. This is optional with
an editor setting, since collecting more information naturally slows the engine
further while profiling.

Fixes godotengine#23715, godotengine#40251, godotengine#29049
@YuriSizov YuriSizov added this to the 4.3 milestone Dec 19, 2023
GuybrushThreepwood-GitHub pushed a commit to GuybrushThreepwood-GitHub/godot that referenced this issue Jan 27, 2024
@reach-satori @GuybrushThreepwood-GitHub
Fix missing time for some script functions in profiler
9b09f32 
Fixes the issue by adding a mechanism by which the functions that were
previously disappearing can be profiled too. This is optional with
an editor setting, since collecting more information naturally slows the engine
further while profiling.

Fixes godotengine#23715, godotengine#40251, godotengine#29049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fix missing script time for some functions in profiler reach-satori/godot-prof-proj
5 participants
@Calinou @mbrlabs @YuriSizov @clayjohn @qarmin