Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with the bezier tracks editor in animationplayer #31783

Open
puthre opened this issue Aug 29, 2019 · 4 comments
Open

Issues with the bezier tracks editor in animationplayer #31783

puthre opened this issue Aug 29, 2019 · 4 comments

Comments

@puthre
Copy link
Contributor

puthre commented Aug 29, 2019

3.1.1.stable.official

Ubuntu 18.04

On a bezier curve track, if you click on the little bezier curve on the right you can now edit the curve. There are however some issues when doing this:

If you select keyframes in it, and try Edit / Scale selection, after you enter a scale ratio, nothing happens. (Also the name is a bit ambiguous in this context as scale can be on the time axis or on the values axis)

If you right click on the tracks list on the left it behaves like it's not there and shows the menu for inserting the keyframes under it.

If you drag the <-> icon right next to "+ Add Track" it will only move the header timeline, you need to scroll so the window will refresh with the updated positions.

If you select the keyframes here, you are no longer able to edit their values from the inspector panel.

Keyframe selection in curve editor is different than the normal keyframe selection. If you select a keyframe then click on the bezier icon, the selection in the bezier editor is the last one you used in the bezier editor not your current keyframe selection.

(Also is there a way to scale the curve vertically? I've copied a bounce track and hoped I could use it for the alpha channel so I needed to scale the values from hundreds to 0..1 interval)

While playing with it I got the following errors in the console

ERROR: _process_operation_list: Error calling method from signal '_clear_selection_for_anim': 'AnimationBezierTrackEdit::_clear_selection_for_anim': Method expected 0 arguments, but called with 1. At: core/undo_redo.cpp:291.
ERROR: _process_operation_list: Error calling method from signal '_select_at_anim': 'AnimationBezierTrackEdit::_select_at_anim': Method expected 0 arguments, but called with 3. At: core/undo_redo.cpp:291.
ERROR: _get_property_list: Condition ' key == -1 ' is true. At: editor/animation_track_editor.cpp:543.

@puthre
Copy link
Contributor Author

puthre commented Aug 30, 2019

Also you can't zoom in below -1 -> 1 interval (which you need if you want to model alpha or scale) and no grid lines are shown in this interval so you are kind of guessing what the actual values are.

@puthre
Copy link
Contributor Author

puthre commented Aug 30, 2019

Seems that most of the issues are fixed in the latest development versions.
I've added #31795 for the zoom in and guidelines problem.

@puthre
Copy link
Contributor Author

puthre commented Aug 31, 2019

I've added #31816 that should also add the values scale feature.

@KoBeWi
Copy link
Member

KoBeWi commented Sep 14, 2020

This should be re-evaluated whether it's still valid in Godot 3.2.3 rc6 and then split into multiple issues. Having both bug and enhancement labels makes this issue difficult to track properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants