Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused signals in AnimationBezierTrackEdit #81820

Closed
Rubonnek opened this issue Sep 17, 2023 · 1 comment · Fixed by #88302
Closed

Unused signals in AnimationBezierTrackEdit #81820

Rubonnek opened this issue Sep 17, 2023 · 1 comment · Fixed by #88302

Comments

@Rubonnek
Copy link
Member

Rubonnek commented Sep 17, 2023

Godot version

master at 4df80b0

System information

Arch Linux

Issue description

There are several signals in AnimationBezierTrackEdit that remain unused, namely timeline_changed, remove_request, close_request, move_selection_begin, move_selection, move_selection_commit, and move_selection_cancel.

Defined within this block:

ADD_SIGNAL(MethodInfo("timeline_changed", PropertyInfo(Variant::FLOAT, "position"), PropertyInfo(Variant::BOOL, "drag")));
ADD_SIGNAL(MethodInfo("remove_request", PropertyInfo(Variant::INT, "track")));
ADD_SIGNAL(MethodInfo("insert_key", PropertyInfo(Variant::FLOAT, "offset")));
ADD_SIGNAL(MethodInfo("select_key", PropertyInfo(Variant::INT, "index"), PropertyInfo(Variant::BOOL, "single"), PropertyInfo(Variant::INT, "track")));
ADD_SIGNAL(MethodInfo("clear_selection"));
ADD_SIGNAL(MethodInfo("close_request"));
ADD_SIGNAL(MethodInfo("move_selection_begin"));
ADD_SIGNAL(MethodInfo("move_selection", PropertyInfo(Variant::FLOAT, "offset")));
ADD_SIGNAL(MethodInfo("move_selection_commit"));
ADD_SIGNAL(MethodInfo("move_selection_cancel"));

Possibly related to issues #31783 and #31924 since the addition of those signals predates those opened issues.

Steps to reproduce

N/A -- this issue is related to engine code and other related issues. See above.

Minimal reproduction project

N/A -- this issue is related to engine code and other related issues. See above.

@TokageItLab
Copy link
Member

TokageItLab commented Sep 18, 2023

I might have forget to remove them. I think they are no longer used after the refactoring at #64647, but I haven't checked what is no longer needed.

@Rubonnek Rubonnek changed the title Unusued signals in AnimationBezierTrackEdit Unused signals in AnimationBezierTrackEdit Sep 18, 2023
@akien-mga akien-mga added this to the 4.3 milestone Feb 13, 2024
@akien-mga akien-mga added enhancement and removed bug labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants