Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: SSIL does not force the editor to redraw for one frame as it should #56723

Open
Calinou opened this issue Jan 12, 2022 · 1 comment
Open

Comments

@Calinou
Copy link
Member

Calinou commented Jan 12, 2022

Related to #54892.

Godot version

4.0.dev (b6b81e8)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 495.46)

Issue description

SSIL does not force the editor to redraw for one frame. However, it should do that since SSIL operates with a one-frame delay. This also breaks SSIL rendering after resizing the project window when low-processor mode is enabled in the Project Settings.

This does not occur for more than one frame if Update Continuously is enabled in the Editor Settings (or if low-processor mode is disabled in the Project Settings).

Epilepsy warning: video below contains some flashing when the window is resized.

ssil_not_rendered_until_redraw.mp4

Steps to reproduce

  • Add some MeshInstance3Ds and a DirectionalLight3D so you can see light bounce around once SSIL is enabled.
  • Add a WorldEnvironment node with a new Environment resource.
  • Enable SSIL in the Environment resource.
  • Resize the editor window. Observe that SSIL will stop working until you move the camera in the 3D editor.

Minimal reproduction project

test_ssil_3.zip

@Calinou Calinou added this to the 4.0 milestone Jan 12, 2022
@Calinou Calinou changed the title Vulkan: SSIL does not force the editor to redraw for one frame Vulkan: SSIL does not force the editor to redraw for one frame as it should Jan 12, 2022
@KoBeWi
Copy link
Member

KoBeWi commented Jun 4, 2022

Tried in alpha 9. The SSIL seems to break only for some editor sizes when resizing and is fixed when you just move cursor over the window.

godot_7m9tNLhNYX.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants