Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: SSIL causes partial viewport flashing when resizing the window #56724

Closed
Calinou opened this issue Jan 12, 2022 · 3 comments · Fixed by #73859
Closed

Vulkan: SSIL causes partial viewport flashing when resizing the window #56724

Calinou opened this issue Jan 12, 2022 · 3 comments · Fixed by #73859

Comments

@Calinou
Copy link
Member

Calinou commented Jan 12, 2022

Godot version

4.0.dev (b6b81e8)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 495.46)

Issue description

SSIL cause partial viewport flashing when resizing the window. This flashing does not occur if SSIL is disabled. This is something I noticed while working on a minimal reproduction project for #56723.

Epilepsy warning: video below contains some flashing when the window is resized.

ssil_not_rendered_until_redraw.mp4

Steps to reproduce

  • Add some MeshInstance3Ds and a DirectionalLight3D so you can see light bounce around once SSIL is enabled.
  • Add a WorldEnvironment node with a new Environment resource.
  • Enable SSIL in the Environment resource.
  • Resize the editor window. Observe that the 3D viewport will occasionally flash in the bottom/right corners when the rendering buffers are reallocated (as a result of the resolution change).

Minimal reproduction project

test_ssil_3.zip

@clayjohn
Copy link
Member

I think this should have been fixed by Bastiaan's recent fixes. Can you confirm?

@clayjohn clayjohn modified the milestones: 4.0, 4.x Feb 23, 2023
@Calinou
Copy link
Member Author

Calinou commented Feb 23, 2023

I can still reproduce this on 4.0.rc 7e79aea and 4.0.rc e930c8d (which is roughly 4.0.rc4):

simplescreenrecorder-2023-02-23_23.43.34.mp4

@BastiaanOlij
Copy link
Contributor

I'm going to have another look at this as I had this fixed at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants