Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Scripts do not save if you choose to save after closing it in the script editor #58622

Closed
Hakunamawatta opened this issue Feb 28, 2022 · 2 comments · Fixed by #58644
Closed

Comments

@Hakunamawatta
Copy link

Hakunamawatta commented Feb 28, 2022

Godot version

4.0 (234eb83)

System information

Linux Mint 20.2

Issue description

If you close an unsaved script in the script editor and choose to save it, the changes won't persist after closing the project. The changes only persist in the same session presumably because of issue #50578.
I believe the issue relates to this line, which chooses to only save built-in scripts on closing (the opposite of what the comment says).

Steps to reproduce

  1. Create a new script file
  2. Try to close it
  3. Choose to save it when it asks whether you want to discard or save changes.
  4. Close to the project list
  5. Open the project again
  6. Open the script (The changes are gone)

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Feb 28, 2022

cc @KoBeWi

@KoBeWi
Copy link
Member

KoBeWi commented Feb 28, 2022

Regression from #50352, the condition should be reversed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants