Add is_built_in() method to Resource

[KoBeWi]

A built-in Resource can be recognized by its path, which may be:

• empty
• containing ::
• starting with local://? idk, I've seen it in few places

There were such checks all over the codebase, but they were inconsistent, which led to some bugs, e.g. #45950 or partially #49086 (_is_built_in_script() is not checking for empty paths, so the issue isn't fully fixed).

To fix inconsistencies I added is_built_in() to resources. I replaced equivalent conditions with this method.

[akien-mga]

Let's merge, but maybe warrants a rebase first to be sure it still builds fine.

[KoBeWi]

Rebased. I also replaced a few more conditions (that likely popped out since the PR was made).

I seen a few partial conditions, which only check for "::", I didn't touch them as I wasn't sure.
There is also String.is_resource_file(), which I didn't replace too.

[akien-mga]

I seen a few partial conditions, which only check for "::", I didn't touch them as I wasn't sure.

Would probably be worth reviewing in a follow-up PR, I guess the intent was to check if it's a builtin resource. What else would use ::?

[KoBeWi]

The ones left out are:

godot/core/string/ustring.cpp

Lines 4338 to 4340 in 78931aa

	bool String::is_resource_file() const {
	return begins_with("res://") && find("::") == -1;
	}

This is used in lots of places. Some of them (res.get_path().is_resource_file()) could be replaced by is_built_in().

godot/editor/dependency_editor.cpp

Lines 174 to 180 in 78931aa

	if (n.find("::") != -1) {
	path = n.get_slice("::", 0);
	type = n.get_slice("::", 1);
	} else {
	path = n;
	type = "Resource";
	}

Doesn't look related to file paths.

godot/editor/editor_file_system.cpp

Lines 122 to 127 in 78931aa

	for (int i = 0; i < files[p_idx]->deps.size(); i++) {
	String dep = files[p_idx]->deps[i];
	int sep_idx = dep.find("::"); //may contain type information, unwanted
	if (sep_idx != -1) {
	dep = dep.substr(0, sep_idx);
	}

No idea here.

godot/editor/editor_node.cpp

Lines 1200 to 1208 in 78931aa

	String path = p_resource->get_path();
	int srpos = path.find("::");
	if (srpos != -1) {
	String base = path.substr(0, srpos);
	if (!get_edited_scene() || get_edited_scene()->get_scene_file_path() != base) {
	show_warning(TTR("This resource can't be saved because it does not belong to the edited scene. Make it unique first."));
	return;
	}
	}

It uses the index of "::", but the performance probably doesn't matter here. Could be replaced.

godot/editor/editor_node.cpp

Lines 2159 to 2168 in 78931aa

	int subr_idx = current_res->get_path().find("::");
	if (subr_idx != -1) {
	String base_path = current_res->get_path().substr(0, subr_idx);
	if (FileAccess::exists(base_path + ".import")) {
	editable_warning = TTR("This resource belongs to a scene that was imported, so it's not editable.\nPlease read the documentation relevant to importing scenes to better understand this workflow.");
	} else {
	if ((!get_edited_scene() || get_edited_scene()->get_scene_file_path() != base_path) && ResourceLoader::get_resource_type(base_path) == "PackedScene") {
	editable_warning = TTR("This resource belongs to a scene that was instantiated or inherited.\nChanges to it won't be kept when saving the current scene.");
	}
	}

Same as above.

godot/editor/filesystem_dock.cpp

Lines 1245 to 1249 in 78931aa

	int sep_pos = r->get_path().find("::");
	if (sep_pos >= 0) {
	extra_path = base_path.substr(sep_pos, base_path.length());
	base_path = base_path.substr(0, sep_pos);
	}

Not sure here.

godot/editor/debugger/editor_debugger_inspector.cpp

Lines 152 to 160 in 78931aa

	String path = var;
	if (path.find("::") != -1) {
	// built-in resource
	String base_path = path.get_slice("::", 0);
	RES dependency = ResourceLoader::load(base_path);
	if (dependency.is_valid()) {
	remote_dependencies.insert(dependency);
	}
	}

Could be replaced probably.

godot/editor/plugins/script_editor_plugin.cpp

Lines 722 to 723 in 78931aa

	} else if (path.find("::") != -1) {
	// built-in script

It checks !path.is_resource_file() later, so it confused me a bit.

[akien-mga]

Thanks!