Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using connection dialog with build-in script opens save file dialog #49086

Closed
KoBeWi opened this issue May 25, 2021 · 1 comment · Fixed by #49372
Closed

Using connection dialog with build-in script opens save file dialog #49086

KoBeWi opened this issue May 25, 2021 · 1 comment · Fixed by #49372

Comments

@KoBeWi
Copy link
Member

KoBeWi commented May 25, 2021

Godot version:

4.0 7ea3a45 / 3.x 94b5a82

Issue description:

LSLQqqZPW1

Steps to reproduce:

  1. Create a build-in script
  2. Try connecting any signal to it
@kleonc
Copy link
Member

kleonc commented May 31, 2021

Caused by #42416.

// Save the current script so the changes can be picked up by an external editor.
save_current_script();

editor->save_resource(resource);

godot/editor/editor_node.cpp

Lines 1099 to 1105 in 5ec8920

void EditorNode::save_resource(const Ref<Resource> &p_resource) {
if (p_resource->get_path().is_resource_file()) {
save_resource_in_path(p_resource, p_resource->get_path());
} else {
save_resource_as(p_resource);
}
}

godot/core/string/ustring.cpp

Lines 4394 to 4396 in 5ec8920

bool String::is_resource_file() const {
return begins_with("res://") && find("::") == -1;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants