Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete not filtering well any longer #59368

Closed
dmaz opened this issue Mar 21, 2022 · 4 comments
Closed

Autocomplete not filtering well any longer #59368

dmaz opened this issue Mar 21, 2022 · 4 comments

Comments

@dmaz
Copy link
Contributor

dmaz commented Mar 21, 2022

Godot version

v4.0.alpha.custom_build [02f61d9]

System information

Windows 10

Issue description

Autocomplete used to filter results much better than it does now...
godot 3.x
image

godot 4
image

godot 4 matching case (shouldn't have to but still doesn't work)
image

I think fuzzy matches should always come last come after direct matches (case ignored) unless context dictates otherwise. but lists should be clean of anything that doesn't fit context in the first place

Steps to reproduce

  • create a new script
  • test autocomplete on just about anything compared to 3.x

Minimal reproduction project

No response

@KoBeWi
Copy link
Member

KoBeWi commented Mar 22, 2022

This is actually duplicate of #40933
Auto-completion doesn't suggest Vector2 at all, with Object classes you will get expected results.

EDIT:
And will be fixed by #43998

@dmaz
Copy link
Contributor Author

dmaz commented Mar 25, 2022

Ok sure but #43998 is over a year old and out of date

@Calinou
Copy link
Member

Calinou commented Mar 25, 2022

Ok sure but #43998 is over a year old and out of date

Feel free to rebase that PR against master and open another PR based on it, while taking #43998 (comment) into account 🙂

@dmaz
Copy link
Contributor Author

dmaz commented Mar 27, 2022

@Calinou here's the new PR... First I did for opensource so I probably got the process wrong.
#59594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants