-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The editor is broken on macOS since TAA was merged #61817
Comments
I can confirm this, it's spamming errors and not rendering any 3D:
|
Actual shader compiler error (at the start of log): Log
|
@bruvzg Are there any other errors before spamming this one? This usually happens when a shader fails to compile, but the relevant error comes before the spam. |
One in the second comment (hidden in the collapsible block) is repeated twice, then it's spamming the |
It looks like an issue in MoltenVK triggered by these lines: godot/servers/rendering/renderer_rd/shaders/scene_forward_clustered.glsl Lines 640 to 641 in e414e09
It seems to be translating them into assignment statements for each individual struct member, and that breaks for array members like |
I'm not home now, but I can try working around this in a bit. |
I put together this quick diff below. It breaks TAA but if someone can confirm that this has no issues on MoltenVK, I should be able to put together a proper workarond for this issue. Diff
|
Could this workaround be done in a way to break TAA only on macOS (with |
@JFonS I tested your patch and it fixes Vulkan Clustered but not Vulkan Mobile. |
@aaronfranke alright, thanks for testing. I didn't fix the mobile renderer, so it's expected to be broken, but I will make sure to include it in the final fix. |
I opened #61850 with a workaround. |
Re-opening because it's still broken with Vulkan Mobile. |
I can confirm this is broken also on Intel Macs (2017 MacBook Pro, Intel i7). Same as mentioned above too, only the mobile backend has errors. |
Godot version
master, this bug happens as of PR #61319
System information
macOS 12.4, M1 Pro (ARM), Godot compiled for ARM.
Issue description
In the latest Godot master, running the editor on an empty project doesn't render anything in 3D, trying to do any action causes the editor to freeze for a long time, and about ten thousand errors are printed per second.
Reverting PR #61319 locally solves this issue.
Steps to reproduce
Minimal reproduction project
Happens on an empty project,
either with Vulkan Mobile or Vulkan Clusteredwith Vulkan Mobile.The text was updated successfully, but these errors were encountered: