Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported variable appears doubled in object inspector #63668

Closed
mcihad opened this issue Jul 30, 2022 · 12 comments · Fixed by #63712
Closed

Exported variable appears doubled in object inspector #63668

mcihad opened this issue Jul 30, 2022 · 12 comments · Fixed by #63712

Comments

@mcihad
Copy link

mcihad commented Jul 30, 2022

Godot version

4.0-13 Alpha

System information

Linux-Ubuntu 22.04 Vulkan RTX 3050

Issue description

exported variable appears double in object inspector

Steps to reproduce

exported variable appears double in object inspector

Minimal reproduction project

Godot4Game.zip

@mcihad
Copy link
Author

mcihad commented Jul 30, 2022

Screenshot from 2022-07-30 10-54-52

@fire fire changed the title exported variable appears double in object inspector Exported variable appears doubled in object inspector Jul 30, 2022
@ThunderSmotch
Copy link

ThunderSmotch commented Jul 30, 2022

Can confirm, also happening to me using Godot 4.0 - Alpha 13, on Windows 10.

@akien-mga
Copy link
Member

Possibly a regression from #58443, CC @object71 @YuriSizov.

@akien-mga akien-mga moved this to To Assess in 4.x Priority Issues Jul 30, 2022
@akien-mga akien-mga moved this from To Assess to Todo in 4.x Priority Issues Jul 30, 2022
@kleonc
Copy link
Member

kleonc commented Jul 30, 2022

#63454 was reopened because of what is reported here, possibly could be closed again in favor of this issue.

@YuriSizov
Copy link
Contributor

Probably should, because it is no longer related to categories.

I guess it's time to rewrite this hacky method and test it again thoroughly.

@mbrlabs
Copy link
Contributor

mbrlabs commented Jul 30, 2022

There is still some weirdness going on when using categories, but it's a bit different. Sure let's close the other issue.

extends Node

@export_category("foo")
@export var my_string: String

@export_category("bar")
@export var my_int: int

image

@YuriSizov
Copy link
Contributor

YuriSizov commented Jul 30, 2022

There is still some weirdness going on when using categories, but it's a bit different.

It's the same as OP, it's just that the duplicates aren't grouped. (Or in other words, categories themselves aren't duplicated).

@object71
Copy link
Contributor

object71 commented Jul 30, 2022

Duplication only seems to happen when it is not a tool script. I did testing and this didn't initially happen but I implemented to stop removal of tool defined variables through _get_property_list a while back around alpha 4 or something and haven't touched the code until it was submitted for alpha 13. The duplication though looking at #63454 was reported on alpha 12.

So it is not my changes that caused the issues it is something else.

@object71
Copy link
Contributor

I will look into that method once more to see if we can rewrite it cleanly

@object71
Copy link
Contributor

Can you test again with the open pull request? Removed the function _update_script_class_properties as a whole as it tried to do something which was too hacky - to rearrange properties. It is prone to bugs as it duplicated and tries to classify and move properties around but that could be achieved by the properties actually being classified correctly in the first place.

@mcihad
Copy link
Author

mcihad commented Aug 1, 2022

same problem exists on macos system
Screen Shot 2022-08-01 at 09 58 44

@stylemistake
Copy link

stylemistake commented Aug 2, 2022

@object71 your PR #63712 fixes it, tested with gdscript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

9 participants