Orphan StringName: SceneMultiplayer

[neikeq]

Godot version

4.0.dev (c2eaaef)

System information

Ubuntu 22.04

Issue description

The "SceneMultiplier" StringName is left orphaned because it's assigned to a static field here:

godot/scene/main/multiplayer_api.cpp

Lines 42 to 48 in 6f273d2

	StringName MultiplayerAPI::default_interface = StringName();
	void MultiplayerAPI::set_default_interface(const StringName &p_interface) {
	ERR_FAIL_COND_MSG(!ClassDB::is_parent_class(p_interface, MultiplayerAPI::get_class_static()), vformat("Can't make %s the default multiplayer interface since it does not extend MultiplayerAPI.", p_interface));
	default_interface = p_interface;
	}

That method is called from:

godot/modules/multiplayer/register_types.cpp

Line 50 in 0ba1046

MultiplayerAPI::set_default_interface("SceneMultiplayer");

One solution is to free the StringName from some sort of cleanup method. The other solution is to create the StringName as static:

-default_interface = p_interface;
+default_interface = StringName(p_interface, true);

Steps to reproduce

• Run Godot in verbose mode -v/--verbose.
• Close Godot and you'll see this message printed in the terminal:

  Orphan StringName: SceneMultiplayer
  StringName: 1 unclaimed string names at exit.
  

Minimal reproduction project

This should be reproducible on all projects. It's also reproducible with the project manager.