-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS.get_unique_id() returns empty string on Web target #82439
Comments
Indeed String OS::get_unique_id() const {
ERR_FAIL_V("");
} I vaguely remember that getting a unique ID on Web may not be possible by design, as it's considered a security issue to let websites identify and thus track users like this. But there should be a proper override that makes this clear, possibly by printing a more explicit error, and maybe a non-unique fallback value. |
This is also documented |
Remove the base error message in `OS`, we no longer really error out this way for not implemented methods. Instead, each platform should override them to provide the context they want. Fixes godotengine#82439.
Agree that a non-unique fallback value would be better, e.g a random uuid |
Remove the base error message in `OS`, we no longer really error out this way for not implemented methods. Instead, each platform should override them to provide the context they want. Fixes godotengine#82439.
Remove the base error message in `OS`, we no longer really error out this way for not implemented methods. Instead, each platform should override them to provide the context they want. Fixes godotengine#82439.
Remove the base error message in `OS`, we no longer really error out this way for not implemented methods. Instead, each platform should override them to provide the context they want. Fixes godotengine#82439. (cherry picked from commit 0a10f09)
Godot version
Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Compatibility) - AMD Radeon RX 5700 XT (Advanced Micro Devices, Inc.; 31.0.21001.45002) - Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz (16 Threads)
System information
Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Compatibility) - AMD Radeon RX 5700 XT (Advanced Micro Devices, Inc.; 31.0.21001.45002) - Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz (16 Threads)
Issue description
OS.get_unique_id() returns empty string
there is an error in developer console as well
Steps to reproduce
func _ready():
print(OS.get_unique_id())
Minimal reproduction project
not needed
The text was updated successfully, but these errors were encountered: