Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightMapGI does not correctly apply GI information to inherited GridMap scenes when reopening scenes #95327

Closed
Tracked by #56033
Arnklit opened this issue Aug 9, 2024 · 2 comments

Comments

@Arnklit
Copy link
Contributor

Arnklit commented Aug 9, 2024

Tested versions

Reproducible on 4.2.2.stable and 4.3.rc3

System information

Godot v4.3.rc3 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4070 Laptop GPU (NVIDIA; 31.0.15.4633) - AMD Ryzen 7 7840HS w/ Radeon 780M Graphics (16 Threads)

Issue description

LightMapGI does not correctly apply GI information to inherited GridMap scenes when reopening scenes

Logs errors like:
modules/gridmap/grid_map.cpp:1326 - Index p_idx = 0 is out of bounds (baked_meshes.size() = 0).

image

Related to #56030

Steps to reproduce

  1. Bake light in a scene where a gridmap is in a child scene. Note that the GI is applied correctly.
  2. Close and open the scene again. note that the GI data is no longer applied to the child gridmap scene and errors are printed.

Minimal reproduction project (MRP)

test_lightmapgi_gridmap_2.zip

@Arnklit Arnklit changed the title BakedLightGI does not correctly apply GI information to inherited GridMap scenes when reopening scenes LightMapGI does not correctly apply GI information to inherited GridMap scenes when reopening scenes Aug 9, 2024
@hakro
Copy link
Contributor

hakro commented Nov 28, 2024

I think this is fixed in master (currently 0eadbdb)

Screencast_20241128_230038.webm

@Calinou
Copy link
Member

Calinou commented Nov 29, 2024

Closing per the above comment. Please comment if you can still reproduce this on master.

@Calinou Calinou closed this as completed Nov 29, 2024
@Calinou Calinou added this to the 4.4 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants