Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable in GDScriptLanguage #100610

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

YYF233333
Copy link
Contributor

This line of code has been commented out for at least four years, nobody should need that anymore.

And without that usage, variable calls is obsoleted (despite initialization), remove to save some space.

Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I doubt the total number of function calls per frame would be useful for performance debugging. Even if we need it, we can always add it back.

@dalexeev dalexeev modified the milestones: 4.x, 4.4 Dec 20, 2024
@akien-mga akien-mga merged commit 0a37e12 into godotengine:master Dec 20, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@YYF233333 YYF233333 deleted the style branch December 21, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants