Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCC warning about potential stringop-overflow in AudioEffectPitcShift #101279

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix GCC warning about potential stringop-overflow in AudioEffectPitcShift #101279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion servers/audio/effects/audio_effect_pitch_shift.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class AudioEffectPitchShift : public AudioEffect {
public:
friend class AudioEffectPitchShiftInstance;

enum FFTSize {
enum FFTSize : unsigned int {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally using unsigned int here over uint32_t or uint64_t because this is old code that still use such "old" types like long. Refactoring it is out of scope for this quick fix.

FFT_SIZE_256,
FFT_SIZE_512,
FFT_SIZE_1024,
Expand Down