Use implicit launch when running a Godot Android project from the editor #101498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows developers to override the default launching activity (`com.godot.game.GodotApp`) with a custom one if desired. Logic is added to fallback to the default launching activity if the implicit launch fails.
dsnopek
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Thanks!
This works great in my testing with PR godot-sdk-integrations/godot-meta-toolkit#1, swapping which activity should be launched by default.
I also tested it with a normal Android smartphone app, both with and without "Show In App Library" enabled, in order to excercise the fallback where it gives the default activity name.
The code looks good to me as well!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows developers to override the default launching activity (
com.godot.game.GodotApp) with a custom one if desired (Should unblock godot-sdk-integrations/godot-meta-toolkit#1).Logic is added to fallback to the default launching activity if the implicit launch fails.
Also did some misc cleanups by adding warnings for the export options that depends on the gradle build.