Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Fix character effect offset. #101532

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 14, 2025

Before After
Screenshot 2025-01-14 at 11 59 00 Screenshot 2025-01-14 at 12 02 19

Note: I have changed the offset effect code in the MRP to make it compatible with wave (add offset to it instead of overriding it):

func _process_custom_fx(char_fx):
	char_fx.offset += Vector2(10, 10)
	return true

Fixes #101496

@bruvzg bruvzg added this to the 4.4 milestone Jan 14, 2025
@bruvzg bruvzg requested a review from a team as a code owner January 14, 2025 10:05
@akien-mga akien-mga merged commit 1ca03ad into godotengine:master Jan 14, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nesting custom bbcodes 'multiplies' offset
2 participants