Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes when pressing enter on project manager screen #101572

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix crashes when pressing enter on project manager screen #101572

merged 1 commit into from
Jan 16, 2025

Conversation

mateuseap
Copy link
Contributor

Closes #101555

Changes made

  • Added a check to ensure that at least one project is selected in the ProjectManager::_open_selected_projects_check_recovery_mode() method.

@Chaosus Chaosus added this to the 4.4 milestone Jan 15, 2025
akien-mga
akien-mga approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should solve the crash fine.

It won't fix the issue that this method assumes only that the first selected project can require using recovery mode, but that's less critical and could be fixed later (cc @rsubtil).

@mateuseap mateuseap marked this pull request as ready for review January 15, 2025 10:28
rsubtil
rsubtil reviewed Jan 15, 2025
View reviewed changes
editor/project_manager.cpp Outdated Show resolved Hide resolved
@mateuseap mateuseap force-pushed the fix/open_selected_projects_check_recovery_mode branch from 9a0040b to f129f22 Compare January 15, 2025 13:14
@mateuseap mateuseap requested a review from rsubtil January 15, 2025 13:15
@mateuseap
Fix ProjectManager::_open_selected_projects_check_recovery_mode() m…
0158efc 
…ethod

Check if at least one project is selected.
@mateuseap mateuseap force-pushed the fix/open_selected_projects_check_recovery_mode branch from f129f22 to 0158efc Compare January 15, 2025 13:18
@akien-mga akien-mga merged commit a79e30a into godotengine:master Jan 16, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@rsubtil rsubtil rsubtil approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash regression topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Godot built from the master branch crashes when pressing enter on the project manager screen
5 participants
@mateuseap @akien-mga @rsubtil @AThousandShips @Chaosus