Fix float constant descriptions not translating on macOS. #101592
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Jan 17, 2025
Ivorforce
force-pushed
the
float-constant-defs-translate-macos
branch
from
5fe132d to
2766543
Compare
bruvzg
approved these changes
Jan 17, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix float descriptions (
PI,Eetc.) not translating properly on macOS.The reason is that
TTRis called statically, at a time where the translation server is not yet started. This leads toTTRreturning the input string unchanged.I discovered it while working on #101547, where it caused an actual problem (because at the time of
TTRcall, not even theStringNametable is initialized).