Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock the StringName::mutex after hashing the string, to spend less time hoarding it unnecessarily. #101606

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Lock the StringName::mutex after hashing the string, to spend less time hoarding it unnecessarily. #101606

merged 1 commit into from
Jan 16, 2025
+18 −28

Conversation

Ivorforce
Copy link
Contributor

This is a tiny optimization. Spending less time on the mutex should speed up highly parallel StringName lookups, especially for long strings.

@Ivorforce Ivorforce requested a review from a team as a code owner January 15, 2025 20:22
@RandomShaper RandomShaper added this to the 4.4 milestone Jan 16, 2025
@Repiteo Repiteo merged commit ce88021 into godotengine:master Jan 16, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 16, 2025

Thanks!

@Ivorforce Ivorforce deleted the stringname-lock-late branch January 16, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
enhancement performance topic:core
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Ivorforce @Repiteo @RandomShaper @akien-mga