iOS: Weak-link MetalFX #101614
Merged
iOS: Weak-link MetalFX #101614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix #101585? |
stuartcarnie
force-pushed
the
metalfx_ios
branch
from
b018428 to
0cd0f88
Compare
|
@Repiteo yes, I've just confirmed it fixes the build. |
|
Looks pretty good! I'll let @bruvzg evaluate tomorrow and start the new beta 1 build once he confirms which solution to go for. |
stuartcarnie
commented
Jan 16, 2025
| @@ -7,6 +7,7 @@ | |||
| objects = { | |||
|
|
|||
| /* Begin PBXBuildFile section */ | |||
| 054F8BE62D38852F00B81423 /* MetalFX.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 054F8BE52D38852F00B81423 /* MetalFX.framework */; settings = {ATTRIBUTES = (Weak, ); }; }; | |||
There was a problem hiding this comment.
Note the Weak attribute, which allows apps to run on OS versions older than iOS 16, which don't have MetalFX.
bruvzg
approved these changes
Jan 16, 2025
|
Additionally, checked it on old macOS (12.7.6, MetalFX only supported on 13+), while we do not specify 
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101585
MetalFX must be weak-linked in the iOS Xcode project.
Important
Supersedes