Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Buildsystem] Break after purging cache #101674

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[Buildsystem] Break after purging cache #101674

merged 1 commit into from
Jan 17, 2025
+2 −1

Conversation

AThousandShips
Copy link
Member

Also added a check to ensure the purge message is only printed if any files were actually purged after the error

Follow-up to:

@AThousandShips AThousandShips added this to the 4.4 milestone Jan 17, 2025
@AThousandShips AThousandShips requested a review from a team as a code owner January 17, 2025 11:31
@AThousandShips AThousandShips mentioned this pull request Jan 17, 2025
Merged
@akien-mga akien-mga merged commit 36a62d0 into godotengine:master Jan 17, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the cache_purge_fix branch January 17, 2025 12:03
@AThousandShips
Copy link
Member Author

Thank you! New personal record on speedy merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:buildsystem
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@AThousandShips @akien-mga