Make slots called in the order of they are connected #12248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@reduz Does this statement still apply? |
|
It also looks like the container for connection will be heavier than VMap, which was basically a vector |
reduz
requested changes
Oct 20, 2017
| VMap<Signal::Target, Signal::Slot> slot_map = s->slot_map; | ||
|
|
||
| int ssize = slot_map.size(); | ||
| OrderedHashMap<Signal::Target, Signal::Slot, Signal::TargetHasher> slot_map = s->slot_map; |
There was a problem hiding this comment.
I wrote the comment above for a reason, and you are ignoring it. This will break.
|
Apologies, but I don't want to merge this. It makes signals more complex and breaks the use case described in my comment. You are making a really big change for what I believe is probably a corner case that can probably be handled in a different way. |
|
Closing as per the above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store slots of signals in OrderedHashMap instead the VMap. So the connected methods can be called with the order they connected.
Fix #4898