-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #12220: Add Decompress Bc5 to Squish #13025
Conversation
This Commit fixes the corrupted file preview described in #12220. Added DecompressColourBc5 function to squish.
Wow you rock
…On Nov 18, 2017 8:41 PM, "Orkun Tezer" ***@***.***> wrote:
This Commit fixes the corrupted file preview described in #12220
<#12220>.
Added DecompressColourBc5 function to squish.
------------------------------
You can view, comment on, or merge this pull request online at:
#13025
Commit Summary
- Fix #12220: Add Decompress Bc5 to Squish
File Changes
- *M* thirdparty/squish/colourblock.cpp
<https://github.com/godotengine/godot/pull/13025/files#diff-0> (83)
- *M* thirdparty/squish/colourblock.h
<https://github.com/godotengine/godot/pull/13025/files#diff-1> (1)
- *M* thirdparty/squish/squish.cpp
<https://github.com/godotengine/godot/pull/13025/files#diff-2> (5)
Patch Links:
- https://github.com/godotengine/godot/pull/13025.patch
- https://github.com/godotengine/godot/pull/13025.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#13025>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF-Z29yvvcuMvfZEdqGORRsHBy2TL07mks5s32sjgaJpZM4QjMXT>
.
|
Thanks! |
So we're forking libsquish?.. Have you tried to propose this change upstream? Edit: They don't seem to have a public issue tracker, so you'd have to send your patch directly to the maintainers listed in their README: https://sourceforge.net/projects/libsquish/files/ Godot's policy is to not modify our thirdparty library unless there is really no way around it and no possibility to contribute our enhancements and bug fixes directly upstream. |
I try solve without touch squish but you can see actually Bc5 and Probably bc4 not working. Yes, i search for issue tracker or push for upstream, i can't find any way to how contirubute. |
How about maintaining this as a patch and maybe wrap it in between markers like |
That's what should be done, yes, but I want to see a discussion with upstream at least start, so far I see no indication that contact with them was made. As upstream dev for various projects, I know that it's very important that downstream users tell you when they want API changes, even more so if they have patches for it already :) |
You're right. I will try contanct with them. |
Thanks! Feel free to put me in CC with my email from https://godotengine.org/contact |
Any news from the Squish devs? |
I put you on cc; since than, no news. |
Seems like things might take a while with upstream, so I merged this manually with comments to properly show what we did: e021097 |
This Commit fixes the corrupted file preview described in #12220.
Added DecompressColourBc5 function to squish.