Duplicate Arrays and Dictionaries when instancing scene in editor #17382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit would probably be better in its own PR to be merged quickly while the other change needs stricter review? Also I can already see users asking for Array and Dictionary deep copy to be exposed to scripting langs. :) |
|
Wait, just realized I forgot to expose the deep parameter 😆 |
Also, add deep (=false) parameter to Array.duplicate and Dictionary.duplicate Fixes godotengine#13971
bojidar-bg
force-pushed
the
13971-path-array-unsaved
branch
from
25fbbc6 to
9f6c0c6
Compare
hpvb
reviewed
Mar 15, 2018
| @@ -35,8 +35,8 @@ | |||
| #include "variant.h" | |||
| #include "vector.h" | |||
|
|
|||
| struct ArrayPrivate { | |||
|
|
|||
| class ArrayPrivate { | |||
There was a problem hiding this comment.
Why? In C++ a Class with only public members is perfectly equivalent to a struct in every way.
There was a problem hiding this comment.
Clang complains otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13971.