Make opening menus with the same parent on mouse focus explicit #20609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermefelipecgs
suggested changes
Aug 2, 2018
guilhermefelipecgs
suggested changes
Aug 2, 2018
YeldhamDev
force-pushed
the
menu_hover_explicit
branch
3 times, most recently
from
bd0e469 to
6f06a0b
Compare
YeldhamDev
force-pushed
the
menu_hover_explicit
branch
from
6f06a0b to
70829c3
Compare
|
Added documentation. @guilhermefelipecgs If you don't have anymore protests, I think this is good to go. |
YeldhamDev
force-pushed
the
menu_hover_explicit
branch
from
70829c3 to
2bc8653
Compare
YeldhamDev
force-pushed
the
menu_hover_explicit
branch
2 times, most recently
from
69c79ae to
4ce28f6
Compare
|
Conflicts solved. |
bojidar-bg
reviewed
Nov 20, 2018
YeldhamDev
force-pushed
the
menu_hover_explicit
branch
from
4ce28f6 to
da7d3c5
Compare
|
@bojidar-bg Thanks for heads-up. The doc suggestions were also implemented. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour happens with any MenuButton without an icon with the same parent, and while it works it has some problems:
So, I made that the behaviour is explicit, by enabling
switch_on_hover, it only happens if both the current MenuButton and the one being hovered have it enabled.I also fixed #20525.