Added native binding for dictionary duplication #28738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karroffel
suggested changes
May 22, 2019
|
@karroffel I have implemented the requested changes and added entries for the duplicate function in both Should hopefully be acceptable now.... Unless I've forgotten something else? |
karroffel
approved these changes
May 23, 2019
Added entry in gdnative_api.json Added function to header as well Fixed versioning
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no native binding for Dictionary duplication.
I took the native binding for array duplication (from modules/gdnative/gdnative/array.cpp)
and modified it for dictionaries.
Was this oversight deliberate? or didn't anyone need to duplicate their dictionaries in native scripts until now?