Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide error messages when PNG save fails #31832

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Provide error messages when PNG save fails #31832

merged 1 commit into from
Sep 1, 2019

Conversation

Xrayez
Copy link
Contributor

@Xrayez Xrayez commented Aug 31, 2019 •
edited
Loading

For testing, can be triggered with image.save_png('res://')

Also helps #31849.

@Xrayez
Copy link
Contributor Author

Xrayez commented Aug 31, 2019

Note: not sure but I think these messages don't show up when using new ERR_FAIL_COND_V_MSG in editor itself, while they do show up in terminal.

@akien-mga akien-mga added this to the 3.2 milestone Aug 31, 2019
@akien-mga akien-mga merged commit 4611977 into godotengine:master Sep 1, 2019
@akien-mga
Copy link
Member

Thanks!

@Xrayez Xrayez deleted the save-png-err-msgs branch September 1, 2019 15:56
@profan profan mentioned this pull request Sep 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Xrayez @akien-mga @Calinou