Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some errors while reparenting nodes in the Scene dock #32143

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Fix some errors while reparenting nodes in the Scene dock #32143

merged 1 commit into from
Sep 20, 2019

Conversation

YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented Sep 15, 2019 •
edited
Loading

@akien-mga Something I noticed, ERR_FAIL_COND_MSG sometimes prints the code, or the message. Is that how it's supposed to work?

@akien-mga akien-mga added this to the 3.2 milestone Sep 20, 2019
@akien-mga akien-mga merged commit 65286c6 into godotengine:master Sep 20, 2019
@akien-mga
Copy link
Member

Thanks!

Something I noticed, ERR_FAIL_COND_MSG sometimes prints the code, or the message. Is that how it's supposed to work?

If there's a _MSG, it should always print the message and not the condition's code. So that would be a bug if it's not doing this reliably.

@YeldhamDev YeldhamDev deleted the scenedock_reparent_fixes branch September 23, 2019 12:07
This was referenced Sep 23, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@YeldhamDev @akien-mga