-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Code Autocompletion #33650
Improved Code Autocompletion #33650
Conversation
You accidentally carried over the other commit. |
04ee844
to
5ccec72
Compare
@aaronfranke @YeldhamDev I made the required changes you can now re-review the code. |
5ccec72
to
5844361
Compare
Doesn't this still break in cases like this? class X:
const xabcxy = 0
const xaxbxcy = 1
func _ready():
print(X.abc<tab>) # Should display both, since X.abcy<tab> displays both |
@bojidar-bg Why would you want that? I don't see the use case for matching non-contiguous characters. By that logic, my previous sentence would match with "donuts" and "contact". Btw, the old code doesn't do that either, so this PR is only an improvement from what I see. |
What I meant to say is that while it is definitely an improvement, it is still possible to reproduce a form of #33425 after it. |
Superseded by #34288, but thanks for the contribution nevertheless! |
Fixes #33425 improved code suggestions. Although work needs to be done on the GUI side to make sure the right letters of suggestions are highlighted.