Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Code Autocompletion #33650

Closed
wants to merge 1 commit into from

Conversation

code-xD
Copy link
Contributor

@code-xD code-xD commented Nov 15, 2019

Fixes #33425 improved code suggestions. Although work needs to be done on the GUI side to make sure the right letters of suggestions are highlighted.

@YeldhamDev
Copy link
Member

YeldhamDev commented Nov 16, 2019

You accidentally carried over the other commit.

editor/quick_open.cpp Outdated Show resolved Hide resolved
@code-xD
Copy link
Contributor Author

code-xD commented Nov 16, 2019

@aaronfranke @YeldhamDev I made the required changes you can now re-review the code.

@akien-mga akien-mga added this to the 4.0 milestone Nov 22, 2019
@bojidar-bg
Copy link
Contributor

Doesn't this still break in cases like this?

class X:
    const xabcxy = 0
    const xaxbxcy = 1
func _ready():
    print(X.abc<tab>) # Should display both, since X.abcy<tab> displays both

@aaronfranke
Copy link
Member

@bojidar-bg Why would you want that? I don't see the use case for matching non-contiguous characters. By that logic, my previous sentence would match with "donuts" and "contact".

Btw, the old code doesn't do that either, so this PR is only an improvement from what I see.

@bojidar-bg
Copy link
Contributor

What I meant to say is that while it is definitely an improvement, it is still possible to reproduce a form of #33425 after it.

@akien-mga
Copy link
Member

Superseded by #34288, but thanks for the contribution nevertheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocompletion doesn't suggest identifiers that begin differently
5 participants