Use MOUSE_FILTER_PASS for all containers #35068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #24083 (but that one would be for 4.0). |
|
Parts of the editor code that sets the filtering to pass in containers should be removed too, these are the ones that I found at first glance: godot/editor/editor_audio_buses.cpp Line 859 in 33be750 |
akien-mga
force-pushed
the
containers-mouse-filter-pass
branch
from
c9ea6f9
to
0c8e4a4
Compare
|
Thanks, removed all occurrences I found in |
akien-mga
commented
Jan 13, 2020
| @@ -1335,7 +1334,6 @@ GraphEdit::GraphEdit() { | |||
| top_layer->set_mouse_filter(MOUSE_FILTER_PASS); | |||
| top_layer->set_anchors_and_margins_preset(Control::PRESET_WIDE); | |||
| top_layer->connect("draw", this, "_top_layer_draw"); | |||
| top_layer->set_mouse_filter(MOUSE_FILTER_PASS); | |||
There was a problem hiding this comment.
This one is not a Container, but the mouse filter was already set to Pass on line 1335.
Containers are meant to forward mouse input to their the Controls they contain. PanelContainer has a visible Panel stylebox, so it still defaults to STOP. Fixes godotengine#34933.
akien-mga
force-pushed
the
containers-mouse-filter-pass
branch
from
0c8e4a4
to
e2bebfb
Compare
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Feb 7, 2020
PR godotengine#35068 made Container (which GraphNode inherits) default to MOUSE_FILTER_PASS, so I removed the manual override, but it turns out that GraphNode's constructor still overrides it to MOUSE_FILTER_STOP. Another fix could be to remove the STOP in the constructor, but I don't know if it's there for a specific reason (e.g. to have GraphNodes STOP by default, but PASS in a specific case). Fixes godotengine#35978.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containers are meant to forward mouse input to their the Controls
they contain.
Fixes #34933.
Putting this up for discussion, I haven't thoroughly tested yet.
Apart from
GridContainerandBoxContainer-derived classes which already defaulted toPASS, this changes the behavior forCenterContainer,MarginContainer,PanelContainer,ScrollContainer,SplitContainer,TabContainer,ViewportContainerand the baseContainer. Might have unforeseen consequences if nobody noticed this discrepancy in 6 years.