Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable Vsync via Compositor by default" #35070

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

akien-mga
Copy link
Member

This reverts commit 9600fd5.

Add comment warning about possible implications of using this option.

Fixes #35038.


Note: The added warning could be removed once further work is done on the feature to prevent halving the framerate. It sounds like for those users, the option somehow behaves as if Vsync happens twice as much?

This reverts commit 9600fd5.

Add comment warning about possible implications of using this option.

Fixes godotengine#35038.
@akien-mga akien-mga added this to the 3.2 milestone Jan 13, 2020
@akien-mga akien-mga requested a review from a team as a code owner January 13, 2020 08:35
@akien-mga akien-mga merged commit 52f44e7 into godotengine:master Jan 13, 2020
@akien-mga akien-mga deleted the revert-34968 branch January 13, 2020 09:13
@hoontee
Copy link
Contributor

hoontee commented Jan 13, 2020

Developers who are affected by the stuttering will enable vsync_via_compositor and inadvertently halve the framerate of a portion of its playerbase. The issue may need to be fixed before 3.2's release.

@Calinou
Copy link
Member

Calinou commented Jan 13, 2020

@hoontee As a workaround, there are command line arguments to forcibly disable/enable this feature regardless of the current project setting:

--enable-vsync-via-compositor
--disable-vsync-via-compositor

@hoontee
Copy link
Contributor

hoontee commented Jan 13, 2020

@Calinou Some games may naturally be locked to 30 FPS, so players might not know that there's a problem; if they do, how would they know how to fix it?

@Calinou
Copy link
Member

Calinou commented Jan 13, 2020

@hoontee I was only proposing a workaround. We don't know if we'll be able to fix the issue before 3.2 is released. It'd be unfortunate to remove the feature entirely, asmany people have reported success using it.

Besides, games limited to 30 FPS on desktop platforms are very uncommon nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.2 beta 6: enabling both use_vsync and sync_via_compositor halves the refresh rate of windowed games
3 participants