Style: Harmonize header guards to style guide [Core] #37290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed all
core/
headers to ensure that they have header guards that match their file name, and and that the last#endif
includes the name of the guard as comment, as in our guidelines: http://docs.godotengine.org/en/latest/community/contributing/code_style_guidelines.html#header-includesI'll leave the rest of the codebase for another contributor to have a look at, but instead of doing it manually, I would suggest writing a script that we can use periodically to parse and fix the codebase, as we do with
misc/scripts/fix_headers.py
. Some special cases need to be handled too as those added in #37143 (i.e. guards which don't directly match their file name to avoid duplicates).To review header guards for all headers: