Input: Drop obsolete versions of SDL gamecontrollerdb #38292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
enhancement
topic:input
cherrypick:3.x
akien-mga
force-pushed
the
input-drop-obsolete-controllerdbs
branch
from
4133db7 to
81600ce
Compare
The 204 and 205 are the older, SDL 2.0.4 and 2.0.5 compatible mappings, but since all new mappings have only been added to the main gamecontrollerdb.txt which overrides the older entries, it doesn't make much sense for us to keep the old databases. We do not support the SDL2 half axes and inverted axes features from gamecontrollerdb.txt, but this only impacts the specific controllers which can use those features, the rest are parsed and used properly. As for godotcontrollerdb.txt, it doesn't make sense for us to maintain our own custom mappings instead of submitting them upstream. The only exception is the Javascript and UWP platforms for which no bindings are available upstream, so we keep those entries.
akien-mga
force-pushed
the
input-drop-obsolete-controllerdbs
branch
from
81600ce to
510e834
Compare
|
Note: Some of the removed mappings might have had a uuid which is not in If you own such a controller, please see https://github.com/gabomdq/SDL_GameControllerDB for instructions on how to generate the mappings for your controller and make a PR there. |
|
Cherry-picked for 3.2.2. |
akien-mga
removed
the
cherrypick:3.x
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
May 11, 2020
Removed by mistake in godotengine#38292 like the Windows `__XINPUT_DEVICE__`, this magic binding is referenced directly in our code.
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
May 11, 2020
Removed by mistake in godotengine#38292 like the Windows `__XINPUT_DEVICE__`, this magic binding is referenced directly in our code. (cherry picked from commit 1c61b31)
kappa54m
pushed a commit
to kappa54m/godot
that referenced
this pull request
May 16, 2020
Removed by mistake in godotengine#38292 like the Windows `__XINPUT_DEVICE__`, this magic binding is referenced directly in our code.
huhund
pushed a commit
to huhund/godot
that referenced
this pull request
Nov 10, 2020
Removed by mistake in godotengine#38292 like the Windows `__XINPUT_DEVICE__`, this magic binding is referenced directly in our code. (cherry picked from commit 1c61b31)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 204 and 205 are the older, SDL 2.0.4 and 2.0.5 compatible mappings,
but since all new mappings have only been added to the main
gamecontrollerdb.txt which overrides the older entries, it doesn't make
much sense for us to keep the old databases.
We do not support the SDL2 half axes and inverted axes features from
gamecontrollerdb.txt, but this only impacts the specific controllers
which can use those features, the rest are parsed and used properly.
As for godotcontrollerdb.txt, it doesn't make sense for us to maintain
our own custom mappings instead of submitting them upstream. The only
exception is the Javascript and UWP platforms for which no bindings are
available upstream, so we keep those entries.
@Faless @vnen WDYT of the pertinence of the Javascript and UWP mappings respectively? For Javascript, should we see if we could have them upstreamed? (provided that they work)
For UWP, it seems to be a placeholder/default controller which could likely be added directly in the
JoypadUWP()constructor?Related to #38151.