Hide autoload category from general project settings #39670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
Calinou
requested changes
Mar 20, 2021
There was a problem hiding this comment.
Note that this bug is no longer reproducible in the new project settings editor that's present in the master branch. Therefore, I suggest remaking this pull request against the 3.x branch where the old project settings editor will still be in use.
Edit: It's still reproducible in master as of c7fefe5.
| @@ -234,7 +234,7 @@ void SectionedInspector::update_category_list() { | |||
| continue; | |||
| } | |||
|
|
|||
| if (pi.name.find(":") != -1 || pi.name == "script" || pi.name == "resource_name" || pi.name == "resource_path" || pi.name == "resource_local_to_scene" || pi.name.begins_with("_global_script")) { | |||
| if (pi.name.find(":") != -1 || pi.name == "script" || pi.name == "resource_name" || pi.name == "resource_path" || pi.name == "resource_local_to_scene" || pi.name.begins_with("_global_script") || pi.name.begins_with("autoload")) { | |||
There was a problem hiding this comment.
Add a comment to explain the change, as it's not obvious at a glance:
Suggested change
| if (pi.name.find(":") != -1 || pi.name == "script" || pi.name == "resource_name" || pi.name == "resource_path" || pi.name == "resource_local_to_scene" || pi.name.begins_with("_global_script") || pi.name.begins_with("autoload")) { | |
| // Hide the Autoload section as it has a dedicated tab in the Project Settings editor. | |
| if (pi.name.find(":") != -1 || pi.name == "script" || pi.name == "resource_name" || pi.name == "resource_path" || pi.name == "resource_local_to_scene" || pi.name.begins_with("_global_script") || pi.name.begins_with("autoload")) { |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39639
Fixes godotengine/godot-proposals#1082
Bugsquad edit: Fixes #24453
While Autoload has its own tab in the Project Settings, it was also added as a category under the general settings. The issue is about incorrect autoload names, but the autoload is unnecessary here and can be removed. This commit removes Autoload from the General tab.