Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CI builds into workflows for each OS #40556

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Jul 21, 2020

Implements this proposal on IRC:

[11:51:51] <Akien> RevoluPowered: So, GitHub Actions has this huge flaw: https://git.luolix.topmunity/t/ability-to-rerun-just-a-single-job-in-a-workflow/17234/16
[11:52:00] <Akien> If one job fails, you have to re-run *all* jobs.
[11:52:35] <Akien> But it seems we could work it around by splitting each job in its own workflow, as it seems "Re-run all jobs" only re-runs all jobs in the current workflow (so currently it doesn't re-run static checks for example)
[11:58:45] <Akien> We can likely split by platform at least (so we for desktop we still have two jobs per workflow)

I also changed the workflow names, since "Godot" seemed redundant. Not sure what to do about "Static Checks / Static Checks".

The main annoying thing is that the builds aren't in order by their name. It seems that they are ordered based on which jobs are the first to be executed.

@akien-mga
Copy link
Member

Needs a rebase to fix the javascript CI as it broke overnight.

@akien-mga
Copy link
Member

The main annoying thing is that the builds aren't in order by their name. It seems that they are ordered based on which jobs are the first to be executed.

Yeah that's a bit annoying but I'm not sure we can solve that. I guess it's not too bad, what's most important is to be able to find the builds that failed (red cross).

@akien-mga
Copy link
Member

CC @RevoluPowered

@akien-mga akien-mga merged commit f4c17da into godotengine:master Jul 23, 2020
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the gha-sep-workflows branch July 23, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants