C#: Fix editor unable to play game after IDE PlayRequest #41362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The editor wasn't clearing the debugger agent settings properly after a processing a play request from an IDE. This caused consequent play attempts to fail if not launched from the IDE, as the game would still attempt and fail to connect to the debugger. The concrete cause: Forgetting to clear the `GODOT_MONO_DEBUGGER_AGENT` environment variable.
neikeq
added
the
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 3.2.3. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The editor wasn't clearing the debugger agent settings properly after a processing a play request from an IDE. This caused consequent play attempts to fail if not launched from the IDE, as the game would still attempt and fail to connect to the debugger.
The concrete cause: Forgetting to clear the
GODOT_MONO_DEBUGGER_AGENTenvironment variable.Fixes godotengine/godot-csharp-visualstudio#7 (This issue was reproducible with VSCode and VSMac/MonoDevelop as well)