Fixes is_action_released firing with no modifiers
#41526
Conversation
|
@Lunatoid Is this still desired? If so, this should be rebased on the latest master branch. While this PR has no conflicts, rebasing is helpful for ensuring the PR still works and it makes testing easier. |
Should fix godotengine#34502, now it checks if the keycode matches and seperately if the modifiers also match. Let's say we have an action that is bound to CTRL+"A" This means that holding CTRL and then pressing and releasing "A" will now appropiately fire the events. One thing to note is that pressing CTRL+"A" and then releasing CTRL while still holding "A" does not fire the release event.
Lunatoid
force-pushed
the
enforce-key-mods-on-release
branch
from
8410f2c to
656e923
Compare
|
Just rebased locally and everything still works. |
There was a problem hiding this comment.
Its buggy for me. MRP attached.
I have 2 actions set up. "z" and "ctrl z". Press Ctrl Z, and both "Only Z" and "Ctrl Z" are printed to the console (expected, although I disagree that this should always be the case, hence #44355). Now, let go of control; both of them are still printing (expected). Now, let go of Z. "Ctrl Z" is still printing... ??? Nothing is currently pressed on the keyboard and it is still printing.
The only way to stop it is by pressing Ctrl Z again. This does not happen in current master.
This is tangentially related to #44355... it is trying to solve a different issue though, and does not solve that one.
|
Closing as this was found to cause issues and was not updated further. I checked and the linked issue is still valid in 4.0 RC 1 though, so that might be something to look into for a future release. |
Should fix #34502
If you have an action like "CTRL + A", it will now fire on both press and release, however if you release "CTRL" while still holding "A" it will not fire the release event.
Also tested with just modifier keys like only "CTRL" or "CTRL+SHIFT" and that still works.