Implemented audio limiter effect with logistics curve #41551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't tell why the old code was acting up, so given the parameters, I completely reimplemented the limiter using a logistics curve and documented everything well. I chose the logistics function because it provides a smooth, semi-linear transition up to a maximum point, which perfectly fits the description of what was needed for this limiter effect.
Calinou
added
bug
cherrypick:3.x
|
@Tony-Goat Is this still desired? If so, it needs to be rebased and tested on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR. |
I can't seem to find the branch in my repo this is from. I'll have to recreate it and resubmit it. |
|
I had to create a new branch on my end, I'll open a new PR and reference this one in it. |
aaronfranke
added
archived
and removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented to address issue #36631
This is more of a soft-clipper than a true audio limiter, however, it corrects the clipping issue at hand until a true limiter can be implemented.
I couldn't tell why the old code was acting up, so given the parameters, I completely reimplemented the audio limiter effect using a logistics curve and documented everything well.
I chose the logistics curve because it provides a smooth, semi-linear transition up to a maximum point, which perfectly fits the description of what was needed for this limiter effect.
This is the old waveform that I captured in Audacity
And this is the new one with the logistics curve soft clipping.