Fix editor inspector refresh not working

[EricEzaM]

Closes #41675

Inspector will cache refresh interval value so it does not need to EDITOR_GET after every interval.

[akien-mga]

Thanks!

[reduz]

This needs to be reverted, as it misunderstood what refresh is for. Its causing the editor to redraw all the time and this is extremely inefficient.

[reduz]

The correct solution is a smart refresh, checking if properties changed and only then update them, but this is a much bigger undertaking

[reduz]

I think you need different logic here. There is a refresh() call which sets the refresh countdown. As you will be refreshing all the time, you can change that to a bool force_update_property_editors; to true instead of setting the refresh countdown.

Then in the refresh logic, you want something like this:

for (Map<StringName, List<EditorProperty *>>::Element *F = editor_property_map.front(); F; F = F->next()) {
	for (List<EditorProperty *>::Element *E = F->get().front(); E; E = E->next()) {
		if (E->get()->has_changed() || force_update_property_editors) {
			E->get()->update_property();
			E->get()->update_reload_status();
		}
	}
}

force_update_property_editors = false;

For the has_changed() method, I think EditorProperty need to be able to figure out when the value inside the object differs from what was edited. One way could be caching the value in EditorProperty::emit_changed, another is doing this manually in every editor which may be too much.

[akien-mga]

Removing cherry-pick label as this was reverted.