Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Give each RigidBody its own DirectBodyState wrapper. #42929

Merged
merged 1 commit into from
Nov 20, 2021
Merged

[3.x] Give each RigidBody its own DirectBodyState wrapper. #42929

merged 1 commit into from
Nov 20, 2021

Conversation

madmiraal
Copy link
Contributor

3.2 version of #42928.

@madmiraal madmiraal added this to the 3.2 milestone Oct 20, 2020
@madmiraal
Copy link
Contributor Author

Rebased following merge of #42168.

@pouleyKetchoupp pouleyKetchoupp mentioned this pull request Jan 8, 2021
Closed
@madmiraal madmiraal requested a review from a team as a code owner March 12, 2021 12:26
Base automatically changed from 3.2 to 3.x March 16, 2021 11:11
@aaronfranke aaronfranke modified the milestones: 3.2, 3.3 Mar 16, 2021
@akien-mga akien-mga modified the milestones: 3.3, 3.4 Mar 26, 2021
@akien-mga akien-mga changed the title [3.2] Give each RigidBody its own DirectBodyState wrapper. [3.x] Give each RigidBody its own DirectBodyState wrapper. Mar 26, 2021
@Chaosus Chaosus modified the milestones: 3.4, 3.5 Nov 8, 2021
pouleyKetchoupp
pouleyKetchoupp approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are welcome for 3.x since #49471 would be a bit much to backport.

It just needs a rebase but it should be good to go.

@akien-mga
Copy link
Member

There's a couple style issues with empty lines at the start of blocks.

@akien-mga akien-mga merged commit 393c795 into godotengine:3.x Nov 20, 2021
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the fix-42877-3.2 branch November 20, 2021 10:10
@madmiraal madmiraal mentioned this pull request Dec 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pouleyKetchoupp pouleyKetchoupp pouleyKetchoupp approved these changes

@akien-mga akien-mga akien-mga approved these changes

@AndreaCatania AndreaCatania Awaiting requested review from AndreaCatania

Assignees
No one assigned
Labels
bug enhancement topic:physics
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
5 participants
@madmiraal @akien-mga @pouleyKetchoupp @aaronfranke @Chaosus